Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manage_api_keys.md #1855

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Update manage_api_keys.md #1855

merged 2 commits into from
Jun 28, 2024

Conversation

CharlesLR-sekoia
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

Pull request was merged, preview was removed.

jeromefellus-sekoia
jeromefellus-sekoia approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@jeromefellus-sekoia jeromefellus-sekoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to indicate the two informations in two separate notes...

  • API keys can't be assigned built-in roles
  • You should first create a custom role before creating API keys

This would make the statement more "step by step". What do you think ?

@CharlesLR-sekoia
Copy link
Contributor Author

good call @jeromefellus-sekoia
I just updated the doc.

@CharlesLR-sekoia CharlesLR-sekoia merged commit 9f94eb0 into main Jun 28, 2024
1 check passed
@CharlesLR-sekoia CharlesLR-sekoia deleted the CharlesLR-sekoia-patch-5 branch June 28, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sengthay Sengthay Awaiting requested review from Sengthay

@ka0ula ka0ula Awaiting requested review from ka0ula

@jeromefellus-sekoia jeromefellus-sekoia Awaiting requested review from jeromefellus-sekoia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CharlesLR-sekoia @jeromefellus-sekoia