Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change scheme to 30 days #1811

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Change scheme to 30 days #1811

merged 3 commits into from
Jun 5, 2024

Conversation

pbivic
Copy link
Contributor

@pbivic pbivic commented Jun 5, 2024

No description provided.

rombernier
rombernier reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@rombernier rombernier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est beau, juste une question, la durée d'archivage par défaut est toujours de 12 mois ?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024 •
edited
Loading

Pull request was merged, preview was removed.

rombernier
rombernier requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@rombernier rombernier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preview is broken or it was the same before ? => it's a preview issue I Think
image

@pbivic
Copy link
Contributor Author

pbivic commented Jun 5, 2024

I didn't know about the preview issue @rombernier . Let's hope it is just this.

@pbivic
Copy link
Contributor Author

pbivic commented Jun 5, 2024

I did a last commit with the changes @ka0ula did on the scheme. No dates are shown for cold storage anymore

@pbivic pbivic merged commit ac035aa into main Jun 5, 2024
1 check passed
@pbivic pbivic deleted the change_scheme branch June 5, 2024 09:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Newest code from pbivic has been published to preview environment

🚀 Latest deployment was built on 2024-06-05 09:50:55 (8a785f456ee77852bea5c0700031e96d023193ba).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rombernier rombernier rombernier approved these changes

@CharlesLR-sekoia CharlesLR-sekoia Awaiting requested review from CharlesLR-sekoia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbivic @rombernier