update(search-regex): add a note for regex #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbivic
approved these changes
May 27, 2024
|
Thx @goudyj . I think there also is an issue on the current doc example as we should escape the "." Character don't we? |
|
Pull request was merged, preview was removed. |
|
@CharlesLR-sekoia what example do you mean ? This one ? |
|
Yes, my bad. Just add that special characters must be escaped as a reminder. |
|
I'm afraid it confuses more than it should be. But we can discuss about it. Escaping special character is part of the principle of a regex itself so it doesn't need a note imo. I merge this and will create another PR if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.