-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Asset Management documentation #1255
Conversation
Pull request was merged, preview was removed. |
Newest code from ka0ula has been published to preview environment 🚀 Latest deployment was built on 2023-09-01 09:48:43 (c84d687eaba19e37c013e6b5a3eb87ce1be38541). |
Je trouve que les 2 phrases devraient etre inversées. D'abord l'explication de ce qu'est une detection property puis en quoi c'est fondamental. "enhance our system's event correlation" => j'aurais dit "enhance Sekoia.io's event correlation" , system on sait pas c'est quoi/qui |
pareil j'aurais inversé definition/plebicite |
|
on pourrait peut etre ajouter une intro à la section "Asset Discovery Rules" pour expliquer que l'asset discovery repose sur un catalogue de règles (actuellement hardcodées) non ? il manque la règle "unique host" |
mais ce sont des détails : tout est super merci 🎉 |
This PR upgrades the documentation of the asset management system to follow its new implementation.
This PR must not be merged before the asset feature is released.