Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the dataRegion #938

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pbivic
Copy link
Contributor

@pbivic pbivic commented May 6, 2024

If the data region is in the URL, then the whoami call will result in 504. We shouldn't encourage users to fill the dataRegion, but to use the central API
For more information see this ticket

@pbivic pbivic requested a review from Darkheir May 6, 2024 14:44
Copy link

github-actions bot commented May 6, 2024

Test Results

13 tests  +12   10 ✅ +9   4s ⏱️ +4s
 1 suites ± 0    3 💤 +3 
 1 files   ± 0    0 ❌ ±0 

Results for commit 24bf8e0. ± Comparison against base commit c9043dc.

This pull request removes 1 and adds 13 tests. Note that renamed tests count towards both.
tests.deep_visibility.test_trigger_s3_logs ‑ test_aws_s3_logs_trigger_parse_data
tests.client.test_auth ‑ test_authentication_integration
tests.client.test_auth ‑ test_get_credentials
tests.client.test_auth ‑ test_get_credentials_request_new_token_only_when_needed
tests.client.test_client ‑ test_authentication_integration
tests.client.test_client ‑ test_list_siem_events
tests.test_helper ‑ test_extract_info
tests.test_helper ‑ test_strip_null_values
tests.test_helper ‑ test_translate_fields
tests.test_sophos_edr_trigger ‑ test_fetch_next_events
tests.test_sophos_edr_trigger ‑ test_forward_next_batches_integration
…

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (c9043dc) to head (24bf8e0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #938   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files         342      342           
  Lines       12452    12456    +4     
  Branches      919      919           
=======================================
+ Hits        11169    11173    +4     
  Misses       1186     1186           
  Partials       97       97           
Flag Coverage Δ
Sophos 86.17% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant