Impr(sdk) Update Sekoia Automation Version #910
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #910 +/- ##
==========================================
- Coverage 89.63% 85.31% -4.33%
==========================================
Files 318 491 +173
Lines 11726 19184 +7458
Branches 839 1078 +239
==========================================
+ Hits 10511 16367 +5856
- Misses 1127 2707 +1580
- Partials 88 110 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Github/manifest.json
Outdated
| "version": "1.9.0" | ||
| "version": "1.9" |
There was a problem hiding this comment.
for my understanding, is 1.9.0 < 1.9 ? do we need to change this version number if only the poetry.lock is updated ?
There was a problem hiding this comment.
Indeed, I have modified it.
CrowdStrike/manifest.json
Outdated
| @@ -29,5 +29,5 @@ | |||
| "name": "CrowdStrike", | |||
| "uuid": "4ffe6bd9-6693-414d-ade0-5ec9fb1b8b2c", | |||
| "slug": "crowdstrike", | |||
| "version": "1.9.1" | |||
| "version": "1.9.2" | |||
There was a problem hiding this comment.
For the others module you updated the minor version
There was a problem hiding this comment.
Indeed, I have harmonized :)
CrowdStrike/pyproject.toml
Outdated
| @@ -8,7 +8,7 @@ authors = [] | |||
| python = ">=3.10,<3.12" | |||
| orjson = "^3.7.7" | |||
| python-dateutil = "^2.8.2" | |||
| sekoia-automation-sdk = { version = "^1.8.1", extras = ["all"] } | |||
| sekoia-automation-sdk = { version = "^1.12.2", extras = ["all"] } | |||
There was a problem hiding this comment.
is extras = ["all"] necessary ? for the other modules, you removed it
There was a problem hiding this comment.
It's related to whether a script is used or not. I've harmonized it.
fix merge cleaning cleaning Update Checkpoint/manifest.json Co-authored-by: lilyus <[email protected]> Cleaning Fix tests update mypy version Try to fix black Run black remove add missing package Fix tests Some fixes again Run black
StephKll3c
force-pushed
the
sc-update-sdk
branch
from
e79bfff to
3407884
Compare
|
I didn't see this PR when I upgraded the version number of the sdk in this one. |
No description provided.