Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Office365: save end date of date range in the checkpoint #1247

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

squioc
Copy link
Collaborator

@squioc squioc commented Jan 10, 2025

Save the end date of each date ranges, computed from the pulling period, in the checkpoint, in order to always progress;
and not wait that the connector caught back the delay to save the end date.

@squioc squioc added the bug Something isn't working label Jan 10, 2025
@squioc squioc requested a review from a team January 10, 2025 17:26
Copy link

github-actions bot commented Jan 10, 2025

Test Results

53 tests  ±0   49 ✅ ±0   2s ⏱️ ±0s
 1 suites ±0    4 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 26b4762. ± Comparison against base commit 6b5f7a4.

♻️ This comment has been updated with latest results.

@squioc squioc merged commit 2365dc6 into main Jan 13, 2025
194 of 196 checks passed
@squioc squioc deleted the fix/Office365Checkpoint branch January 13, 2025 16:39
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.49%. Comparing base (6b5f7a4) to head (26b4762).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
Office365/office365/management_api/connector.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1247      +/-   ##
==========================================
+ Coverage   91.15%   91.49%   +0.33%     
==========================================
  Files          50       63      +13     
  Lines        2251     2668     +417     
  Branches       89       89              
==========================================
+ Hits         2052     2441     +389     
- Misses        167      195      +28     
  Partials       32       32              
Flag Coverage Δ
Office365 93.28% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants