Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: SentinelOne detailed alert view (351) #1241

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

vg-svitla
Copy link
Collaborator

@vg-svitla vg-svitla commented Jan 7, 2025

Fixes 351

@vg-svitla vg-svitla requested a review from squioc January 7, 2025 07:56
@vg-svitla vg-svitla changed the title Feature: SentinelOne detailed alert view Feature: SentinelOne detailed alert view (351) Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Test Results

 1 files   -    74   1 suites   - 74   2m 16s ⏱️ - 4m 58s
59 tests  - 1 085  55 ✅  - 1 040  4 💤  - 41  0 ❌  - 4 
59 runs   - 1 110  55 ✅  - 1 063  4 💤  - 43  0 ❌  - 4 

Results for commit 1a3f622. ± Comparison against base commit 4075ac2.

This pull request removes 1086 and adds 1 tests. Note that renamed tests count towards both.
tests.async_client.test_http_client ‑ test_github_client_audit_log_url
tests.async_client.test_http_client ‑ test_github_client_auth_headers
tests.async_client.test_http_client ‑ test_github_client_get_audit_logs_with_api_key
tests.async_client.test_http_client ‑ test_github_client_get_audit_logs_with_pem_file_content
tests.async_client.test_http_client ‑ test_github_client_get_audit_logs_with_pem_file_content_1
tests.async_client.test_http_client ‑ test_github_client_get_audit_logs_with_pem_file_content_3
tests.async_client.test_http_client ‑ test_github_client_init_error
tests.async_client.test_http_client ‑ test_github_client_token_refresher
tests.async_client.test_token_refresher ‑ test_github_refresher_access_token_for_installation_url
tests.async_client.test_token_refresher ‑ test_github_refresher_get_token
…
tests.singularity.test_client ‑ test_alert_details

Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the work.

@squioc squioc merged commit 915f5ce into main Jan 9, 2025
171 of 173 checks passed
@squioc squioc deleted the feature/sentinelone_detailed_alerts branch January 9, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants