Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for changing alert status by name #1214

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

ysindel
Copy link
Contributor

@ysindel ysindel commented Dec 9, 2024

No description provided.

@ysindel ysindel requested review from gaelmuller and squioc December 9, 2024 19:47
@ysindel ysindel self-assigned this Dec 9, 2024
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Dec 10, 2024

Test Results

100 tests  +43   99 ✅ +46   2s ⏱️ - 1m 7s
  1 suites ± 0    1 💤  -  3 
  1 files   ± 0    0 ❌ ± 0 

Results for commit ecf3a25. ± Comparison against base commit 07138a6.

This pull request removes 57 and adds 100 tests. Note that renamed tests count towards both.
tests.agents.test_init_scan ‑ test_init_scan
tests.agents.test_isolation ‑ test_endpoint_deisolation
tests.agents.test_isolation ‑ test_endpoint_isolation
tests.agents.test_isolation ‑ test_isolation_and_deisolation_actions
tests.deep_visibility.test_query ‑ test_list_remote_scripts_integration
tests.deep_visibility.test_query ‑ test_query
tests.deep_visibility.test_query ‑ test_query_canceled
tests.deep_visibility.test_query ‑ test_query_exhausted_retries
tests.deep_visibility.test_query ‑ test_query_failed
tests.iocs.test_create_iocs ‑ test_create_iocs
…
tests.ic_oc_triggers.test_alerts ‑ test_alert_trigger_filter_by_rule
tests.ic_oc_triggers.test_alerts ‑ test_comment_trigger_filter_by_rule
tests.ic_oc_triggers.test_alerts ‑ test_comment_trigger_filter_notification_function
tests.ic_oc_triggers.test_alerts ‑ test_invalid_events_dont_triggers_comments_added
tests.ic_oc_triggers.test_alerts ‑ test_securityalertstrigger_handle_alert_invalid_message
tests.ic_oc_triggers.test_alerts ‑ test_securityalertstrigger_handle_alert_send_message
tests.ic_oc_triggers.test_alerts ‑ test_securityalertstrigger_handler_dispatch_alert_message
tests.ic_oc_triggers.test_alerts ‑ test_securityalertstrigger_init
tests.ic_oc_triggers.test_alerts ‑ test_securityalertstrigger_retrieve_alert_from_api
tests.ic_oc_triggers.test_alerts ‑ test_securityalertstrigger_retrieve_alert_from_api_exp_raised
…
This pull request removes 4 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.
tests.agents.test_isolation ‑ test_isolation_and_deisolation_actions
tests.deep_visibility.test_query ‑ test_list_remote_scripts_integration
tests.rso.test_execute ‑ test_execute_remote_scripts_integration
tests.threats.test_get_malwares ‑ test_get_malware_integration
tests.ic_oc_triggers.test_intelligence ‑ test_run

♻️ This comment has been updated with latest results.

@ysindel ysindel force-pushed the add-feat-update-alert-status-by-name branch from 4c96be5 to ecf3a25 Compare December 16, 2024 14:01
@ysindel ysindel merged commit 68d4023 into main Dec 16, 2024
97 checks passed
@ysindel ysindel deleted the add-feat-update-alert-status-by-name branch December 16, 2024 14:09
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.39%. Comparing base (07138a6) to head (ecf3a25).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1214      +/-   ##
==========================================
+ Coverage   91.27%   91.39%   +0.12%     
==========================================
  Files          42       43       +1     
  Lines        1994     2023      +29     
  Branches       87       87              
==========================================
+ Hits         1820     1849      +29     
  Misses        143      143              
  Partials       31       31              
Flag Coverage Δ
Sekoia.io 91.95% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants