-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trend Micro Vision One OAT connector #1212
Conversation
Test Results10 tests - 47 10 ✅ - 43 0s ⏱️ - 2m 14s Results for commit dffecd8. ± Comparison against base commit a433b23. This pull request removes 57 and adds 10 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the work.
Can you mutualize the code for the Workbench connector and the code for the OAT one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can part of the TrendMicroVisionOneOATConnector
be mutualized with TrendMicroVisionOneWorkbenchConnector
? I saw common methods between the two connectors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the work.
No description provided.