Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trend Micro Vision One OAT connector #1212

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Conversation

lvoloshyn-sekoia
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Dec 9, 2024

Test Results

10 tests   - 47   10 ✅  - 43   0s ⏱️ - 2m 14s
 1 suites ± 0    0 💤  -  4 
 1 files   ± 0    0 ❌ ± 0 

Results for commit dffecd8. ± Comparison against base commit a433b23.

This pull request removes 57 and adds 10 tests. Note that renamed tests count towards both.
tests.agents.test_init_scan ‑ test_init_scan
tests.agents.test_isolation ‑ test_endpoint_deisolation
tests.agents.test_isolation ‑ test_endpoint_isolation
tests.agents.test_isolation ‑ test_isolation_and_deisolation_actions
tests.deep_visibility.test_query ‑ test_list_remote_scripts_integration
tests.deep_visibility.test_query ‑ test_query
tests.deep_visibility.test_query ‑ test_query_canceled
tests.deep_visibility.test_query ‑ test_query_exhausted_retries
tests.deep_visibility.test_query ‑ test_query_failed
tests.iocs.test_create_iocs ‑ test_create_iocs
…
tests.test_trigger_email_sec ‑ test_fetch_empty_content
tests.test_trigger_email_sec ‑ test_fetch_event
tests.test_trigger_email_sec ‑ test_saving_checkpoint
tests.test_trigger_email_sec ‑ test_start_consumers
tests.test_trigger_email_sec ‑ test_stop_consumers
tests.test_trigger_email_sec ‑ test_supervise_consumers
tests.test_trigger_vision_one_oat ‑ test_fetch_events
tests.test_trigger_vision_one_oat ‑ test_long_next_batch_should_not_sleep
tests.test_trigger_vision_one_workbench ‑ test_fetch_events
tests.test_trigger_vision_one_workbench ‑ test_long_next_batch_should_not_sleep

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work.
Can you mutualize the code for the Workbench connector and the code for the OAT one?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can part of the TrendMicroVisionOneOATConnector be mutualized with TrendMicroVisionOneWorkbenchConnector? I saw common methods between the two connectors.

@lvoloshyn-sekoia lvoloshyn-sekoia marked this pull request as ready for review December 17, 2024 09:06
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the work.

@squioc squioc merged commit 38de486 into main Dec 17, 2024
106 of 108 checks passed
@squioc squioc deleted the lv/add_trend_micro_oat branch December 17, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants