Merge pull request #1184 from SEKOIA-IO/fix/SophosXDRRateLimit

Sophos: add ratelimit per day
SEKOIA-IO · Nov 20, 2024 · db0001e · db0001e
2 parents 0062bff + 6e889d6
commit db0001e
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 5 deletions.
diff --git a/Sophos/CHANGELOG.md b/Sophos/CHANGELOG.md
@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## 2024-11-20 - 1.17.2
+
+### Fixed
+
+- Add the ratelimit per day
+- Increase the frequency to 5 minutes
+
 ## 2024-10-08 - 1.17.1
 
 ### Fixed

diff --git a/Sophos/connector_sophos_xdr_query.json b/Sophos/connector_sophos_xdr_query.json
@@ -8,7 +8,7 @@
       "frequency": {
         "type": "integer",
         "description": "Batch frequency in seconds",
-        "default": 60
+        "default": 300
       },
       "chunk_size": {
         "type": "integer",
@@ -33,4 +33,4 @@
     "type": "object"
   },
   "uuid": "d7052d5e-0ccc-403f-928a-f63cb71b2e0c"
-}
+}
diff --git a/Sophos/manifest.json b/Sophos/manifest.json
@@ -38,7 +38,7 @@
   "name": "Sophos",
   "uuid": "0de5216e-19b0-4ad3-9b91-a547cfaf52ca",
   "slug": "sophos",
-  "version": "1.17.1",
+  "version": "1.17.2",
   "categories": [
     "Endpoint"
   ]

diff --git a/Sophos/sophos_module/client/__init__.py b/Sophos/sophos_module/client/__init__.py
@@ -16,13 +16,15 @@ def __init__(
         ratelimit_per_second: int = 10,
         ratelimit_per_minute: int = 100,
         ratelimit_per_hour: int = 1000,
+        ratelimit_per_day: int = 200000,
     ):
         super().__init__()
         self.auth = auth
         adapter = LimiterAdapter(
             per_second=ratelimit_per_second,
             per_minute=ratelimit_per_minute,
             per_hour=ratelimit_per_hour,
+            per_day=ratelimit_per_day,
             max_retries=Retry(total=nb_retries, backoff_factor=1, status_forcelist=[429, 500, 502, 503, 504]),
         )
         self.mount("http://", adapter)
@@ -39,13 +41,15 @@ def __init__(
         ratelimit_per_second: int = 10,
         ratelimit_per_minute: int = 100,
         ratelimit_per_hour: int = 1000,
+        ratelimit_per_day: int = 200000,
     ) -> None:
         super().__init__(
             auth=auth,
             nb_retries=nb_retries,
             ratelimit_per_second=ratelimit_per_second,
             ratelimit_per_minute=ratelimit_per_minute,
             ratelimit_per_hour=ratelimit_per_hour,
+            ratelimit_per_day=ratelimit_per_day,
         )
 
     def list_siem_events(self, parameters: dict[str, Any] | None = None) -> requests.Response:

diff --git a/Sophos/trigger_sophos_xdr_query.json b/Sophos/trigger_sophos_xdr_query.json
@@ -8,7 +8,7 @@
       "frequency": {
         "type": "integer",
         "description": "Batch frequency in seconds",
-        "default": 60
+        "default": 300
       },
       "chunk_size": {
         "type": "integer",
@@ -34,4 +34,4 @@
   },
   "results": {},
   "uuid": "d7052d5e-0ccc-403f-928a-f63cb71b2e0c"
-}
+}