Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sesitive match python update #13

Merged
merged 8 commits into from
Aug 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
18 changes: 18 additions & 0 deletions .appinspect.manualcheck.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Required by pipeline
check_for_builtin_functions:
comment: 'Checking for built-in functions'

check_for_generic_operating_system_services:
comment: 'Checking for generic operating system services'

check_for_plain_text_credentials_in_python:
comment: 'Checking for plain text credentials in Python'

check_for_insecure_http_calls_in_python:
comment: 'Checking for insecure HTTP calls in Python'

check_for_secret_disclosure:
comment: 'Checking for secret disclosure'

check_for_executable_flag:
comment: 'Checking for executable flag'
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v2
with:
python-version: 3.7
python-version: 3.9

- name: Package Splunk App with CLI
run: |
Expand Down
6 changes: 6 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,9 @@ __pycache__/
# Splunk local configuration files
sekoia.io/local/
sekoia.io/metadata/local.meta

.venv
.venv-3.11
.venv-3.10
dist
.idea
17 changes: 17 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

## 2024-07-30 - 1.3.0

### Changed

- Remove support of python2
- Add `case_sensitive_match` option to the configuration
- Upgrade python build time version to 3.10
- Custom wrapper over slim to have backward compatibility lower versions of python, as it is used by the splunk
2 changes: 1 addition & 1 deletion sekoia.io/app.manifest
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"id": {
"group": null,
"name": "sekoia.io",
"version": "1.2.2"
"version": "1.3.0"
},
"author": [
{
Expand Down
3 changes: 2 additions & 1 deletion sekoia.io/bin/sekoia_indicators.py
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,9 @@ def indicator_to_kv(self, indicator, api_root_url):
elif server_root_url.endswith("/api/"):
server_root_url = server_root_url[:-5]

# Applying _key to lowercase to avoid case sensitivity
result = {
"_key": value.strip("'"),
"_key": value.strip("'").lower(),
"indicator_id": indicator["id"],
"server_root_url": server_root_url,
"valid_until": indicator.get("valid_until"),
Expand Down
2 changes: 1 addition & 1 deletion sekoia.io/default/app.conf
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ setup_view = setup
[launcher]
author = [email protected]
description = Search your logs with Indicators of Compromise (IoCs) from SEKOIA.IO.
version = 1.2.2
version = 1.3.0

[package]
check_for_updates = 1
Expand Down
1 change: 1 addition & 0 deletions sekoia.io/default/transforms.conf
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ max_matches = 1
collection = sekoia_iocs_url
external_type = kvstore
fields_list = _key,type,valid_until,indicator_id
case_sensitive_match = false
max_matches = 1

[sekoia_iocs_md5]
Expand Down
Loading
Loading