Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the Concentration ROC diagram and adding the ROC and Molchgan plots using the alarm-based approach #254

Merged
merged 7 commits into from
Jun 10, 2024

Conversation

Biondini
Copy link
Contributor

@Biondini Biondini commented May 2, 2024

I added two new plots that allow to analyse probabilistic models using the alarm-based approach.
In particular i added the ROC and Molchan diagrams derived from the contingency table.
The new functions are called "plot_ROC_diagram()" and "plot_Molchan_diagram()".

I changed the name of the already availabe "plot_ROC()" function into "plot_concentration_ROC()".
The new 2 functions and the modiefied plot_concentration_ROC() are also inserted in the tutorial for the evaluation of gridded forecasts.

pyCSEP Pull Request Checklist

Please check out the contributing guidelines for some tips
on making pull requests to pyCSEP.

Fixes issue #(please fill in or delete if not needed).

Type of change:

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Unpublished science feature (This may require a science review)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

I added the code to plot the contingency_ROC and the contingency_Molchan in the .\csep\utils\plots.py.
I also inserted the two funcions in the tutorial of "gridded_forecast_evaluation.py"
i inserted the two function in the example "gridded_forecast_evaluation.py"
Copy link
Collaborator

@pabloitu pabloitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR looks good to go

@fabiolsilva fabiolsilva merged commit 21d275c into SCECcode:main Jun 10, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants