Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two new pyCSEP tutorials and three input files #251

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

bayonato89
Copy link
Contributor

@bayonato89 bayonato89 commented Apr 10, 2024

pyCSEP Pull Request Checklist

Please check out the contributing guidelines for some tips
on making pull requests to pyCSEP.

Fixes issue #(please fill in or delete if not needed).

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (this pull request adds no new code)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@pabloitu pabloitu self-requested a review October 22, 2024 17:19
Copy link
Collaborator

@pabloitu pabloitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR and tutorials looks super. However, and not strictly related to this PR, there is not much structure with the tutorial/examples/notebook files of pycsep. We should make a follow-up PR to rearrange the files contained in both pycsep/examples/tutorials and pycsep/notebooks, and create subfolders to contain all the data therein. Perhaps also create an en/ and es/ folder to separate by languages.

@fabiolsilva fabiolsilva merged commit c13a77e into SCECcode:main Oct 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants