Fix writing catalog csv files on Windows #235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: on Windows,
csep.catalogs.AbstractBaseCatalog.write_ascii()
interleaves every entry with an empty line, like so.:Those files can also not be read by
csep.load_catalog()
(IndexError: list index out of range
)Solution: add
newline=''
toopen(filename, write_string)
, see docs.python.org/3/library/csv (footnote) and stackoverflow.com/a/3348664FYI:
.write_json()
is not affected, and there is no further occurrence in pyCSEP that needs to be fixed (b/c there is no further use ofcsv.DictWriter
orcsv.writer
).Type of change:
Checklist: