Issue 36 #41
Merged
Issue 36 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot use vertikal skips inside a paragraph with line
numbering. That would again result in similar issues like reledmac
using plain latex sectioning commands behind \eledxxxx. So remove
vskips from the sectioning macros and use XSLT hooks for adding
vertical space outside of \pstart\eledxxxx[...]{...}\pend.
We also provide macros to make font styling in section titles more
configurable.
Related to #36.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes #36 by adding a workaround for issues with reledmac's sectioning commands
\eledxxxxas filed in maieul/ledmac#976 and maieul/ledmac#977.The workaround rewrites these section commands like so:
The redefinition does not contain vertical spacing, because using this inside
\pstart...\pendresults in similar issues. Instead, we add vertical spacing outside line numbering using XSLT hooks inxsl/latex/libtext.xsl.