Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-dynamic-page): keyboard handling #7990

Merged
merged 4 commits into from
Dec 18, 2023
Merged

feat(ui5-dynamic-page): keyboard handling #7990

merged 4 commits into from
Dec 18, 2023

Conversation

kineticjs
Copy link
Contributor

@kineticjs kineticjs commented Dec 11, 2023 •
edited
Loading

  1. the focused element of the DynamicPageTitle is now a separate span (to allow proper aria attributes in a pending separate change)
  2. the DynamicPageTitle now fires private "_toggle-title" event to notify the DynamicPage whenever the title's internal root element [rather than any other internal element] was pressed; This is required to allow the user toggle the title on press ENTER/SPACE, as the DynamicPage acts as a mediator
  3. add "focusExpandButton"/"focusPinButton" methods to the DynamicPageTitle to allow retain focus of the corresponding button after it was clicked: Now the focus is retained via the DynamicPage requesting to focus the corresponding inner button after rendering
  4. add "fastNavigation" to DynamicPageTitle for F6 navigation

@kineticjs kineticjs marked this pull request as ready for review December 11, 2023 09:11
@dobrinyonkov dobrinyonkov merged commit f379b8e into SAP:dynamic-page Dec 18, 2023
8 checks passed
dobrinyonkov added a commit to dobrinyonkov/ui5-webcomponents that referenced this pull request Feb 5, 2024
@dobrinyonkov @kineticjs @PetyaMarkovaBogdanova
Dynamic page (#4)
6855665 
* test: do not merge

* feat(ui5-dynamic-page): poc

* feat(ui5-dynamic-page): snap on scroll pin expand collapse

* feat(ui5-dynamic-page): add floating footer styling and animation (SAP#7857)

* feat(ui5-dynamic-page): snap on scroll pin expand collapse

* feat(ui5-dynamic-page): add breadcrumbs responsiveness (SAP#7844)

* feat(ui5-dynamic-page): ensure visibility of content outside overflow (SAP#7845)

* feat(ui5-dynamic-page): ensure visibility of title content that never overflows

* feat(ui5-dynamic-page) actions style corrected

Co-authored-by: Dobrin Dimchev <[email protected]>

* feat(ui5-dynamic-page): sizing of toolbar wrappers corrected

* feat(ui5-dynamic-page): apply review feedback

---------

Co-authored-by: Dobrin Dimchev <[email protected]>

* feat(ui5-dynamic-page): footer no longer takes space when hidden (SAP#7904)

* feat(ui5-dynamic-page): prevent unnecessary content overflow when footer hidden

* feat(ui5-dynamic-page): move scroll listener to the new scroll container

* feat(ui5-dynamic-page): add header padding (SAP#7921)

* feat(ui5-dynamic-page): add responsive paddings (SAP#7923)

* build: align with new build process

* feat(ui5-dynamic-page): fit content that has 100% height (SAP#7928)

* feat(ui5-dynamic-page): fit content that has 100% height

* feat(ui5-dynamic-page): correct import

* feat(ui5-dynamic-page): add tests

* feat(ui5-dynamic-page): keyboard handling (SAP#7990)

* feat(ui5-dynamic-page): keyboard handling

* feat(ui5-dynamic-page): add focus span

* fix: add expand and focus on title click

---------

Co-authored-by: Dobrin Dimchev <[email protected]>

* fix(ui5-dynamic-page): theme styling (SAP#7966)

fix(ui5-dynamic-page): apply theme styles

Co-authored-by: PetyaMarkovaBogdanova <[email protected]>

* feat(ui5-dynamic-page): screen reader support (SAP#7997)

* feat(ui5-dynamic-page): screen reader support

* feat(ui5-dynamic-page): add tests

* feat(ui5-dynamic-page): add general interaction tests (SAP#8056)

* docs(ui5-dynamic-page): story and docs added (SAP#8031)

fix(ui5-dynamic-page): story and docs added

Co-authored-by: PetyaMarkovaBogdanova <[email protected]>

* feat(ui5-dynamic-page): add general API tests (SAP#8115)

* feat(ui5-dynamic-page): proper docs added (SAP#8130)

Co-authored-by: PetyaMarkovaBogdanova <[email protected]>

* chore: align docs to new build scripts

* chore: use framework's debounce method

---------

Co-authored-by: PetyaMarkovaBogdanova <[email protected]>
Co-authored-by: Diana Pazheva <[email protected]>
Co-authored-by: PetyaMarkovaBogdanova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobrinyonkov dobrinyonkov dobrinyonkov approved these changes

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova Awaiting requested review from PetyaMarkovaBogdanova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kineticjs @PetyaMarkovaBogdanova @dobrinyonkov