fix(ui5-popover): fix "containing block" position issue #7870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeodorTaushanov
changed the title
TeodorTaushanov
requested review from
a team,
pskelin,
nnaydenow and
BorisDafov
BorisDafov
suggested changes
Nov 22, 2023
packages/main/src/Dialog.ts
Outdated
| * <b>Note:</b> We don't recommend nesting popup-like components (<code>ui5-dialog</code>, <code>ui5-popover</code>) inside other components containing z-index. | ||
| * This might break z-index management. | ||
| * <b>Note: </b> We recommend placing popup-like components (<code>ui5-dialog</code> and <code>ui5-popover</code>) | ||
| * outside any other components. Preferably the popup-like components should be placed in |
There was a problem hiding this comment.
I suggest (here and below):
Preferably, the popup-like components should be placed in an upper level HTML element,
alexandar-mitsev
requested changes
Nov 22, 2023
TeodorTaushanov
changed the title
georgimkv
suggested changes
Nov 24, 2023
alexandar-mitsev
approved these changes
Nov 27, 2023
BorisDafov
reviewed
Nov 28, 2023
PetyaMarkovaBogdanova
pushed a commit
that referenced
this pull request
Dec 5, 2023
* fix(ui5-popover): fix containing block positioning issue
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7856