fix(ui5-slider): up and down arrow behavior in RTL mode #10037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Okiana
reviewed
Oct 17, 2024
packages/main/src/SliderBase.ts
Outdated
| @@ -719,11 +717,19 @@ abstract class SliderBase extends UI5Element { | |||
| return isUpAction ? step : step * -1; | |||
| } | |||
|
|
|||
| static _isDecreaseValueAction(e: KeyboardEvent) { | |||
| static _isDecreaseValueAction(e: KeyboardEvent, directionStart: DirectionStart) { | |||
There was a problem hiding this comment.
I was not able to find this function to be called anywhere in the project. I've tested in the test page to put breakpoint in it and aslo it's not called. Do we still need it?
There was a problem hiding this comment.
So did I :) We can discuss it with the team and remove it if it is no longer needed.
Okiana
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9967