[FEATURE] Resolvers: Allow ranges / npm tags for version resolution #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
force-pushed
the
resolver-use-npm-tags
branch
from
0c648ec
to
a475330
Compare
matz3
changed the title
matz3
force-pushed
the
resolver-use-npm-tags
branch
from
2e1025a
to
a69786d
Compare
matz3
force-pushed
the
resolver-use-npm-tags
branch
from
d1da6d6
to
2faad30
Compare
d3xter666
reviewed
Sep 4, 2023
flovogt
force-pushed
the
resolver-use-npm-tags
branch
2 times, most recently
from
336eddc
to
ce4243e
Compare
matz3
added a commit
to SAP/ui5-cli
that referenced
this pull request
Sep 5, 2023
Updates according to new features via SAP/ui5-project#649 JIRA: CPOUI5FOUNDATION-722
The framework version resolution now supports all valid node semver ranges and uses tags from the corresponding registry for version resolution (not supported for Sapui5MavenSnapshotResolver).
- Adds tests to clarify that only -SNAPSHOT ranges should use the "includePrerelease" behavior. - Remove duplicate tests - Remove obsolete SEMVER regular expression There is no real need to have it in sync with the configuration schema. If semver would change something, we would anyways not notice it via that test as both expressions are defined by us.
matz3
force-pushed
the
resolver-use-npm-tags
branch
from
6f5c7c1
to
8d760d7
Compare
d3xter666
approved these changes
Sep 5, 2023
matz3
added a commit
to SAP/ui5-cli
that referenced
this pull request
Sep 5, 2023
Updates according to new features via SAP/ui5-project#649 JIRA: CPOUI5FOUNDATION-722
matz3
added a commit
to SAP/ui5-cli
that referenced
this pull request
Sep 5, 2023
Updates according to new features via SAP/ui5-project#649 JIRA: CPOUI5FOUNDATION-722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The framework version resolution now supports all valid node semver
ranges and uses tags from the corresponding registry for version
resolution (not supported for Sapui5MavenSnapshotResolver).
JIRA: CPOUI5FOUNDATION-722