Skip to content

Commit

Permalink
Fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
d3xter666 committed Jul 27, 2023
1 parent eff2a50 commit b3759ff
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
8 changes: 8 additions & 0 deletions test/lib/graph/helpers/ui5Framework.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ test.serial("enrichProjectGraph", async (t) => {
cacheMode: undefined,
cwd: dependencyTree.path,
version: dependencyTree.configuration.framework.version,
ui5HomeDir: undefined,
providedLibraryMetadata: undefined
}], "Sapui5Resolver#constructor should be called with expected args");

Expand Down Expand Up @@ -319,6 +320,7 @@ test.serial("enrichProjectGraph: With versionOverride", async (t) => {
cacheMode: undefined,
cwd: dependencyTree.path,
version: "1.99.9",
ui5HomeDir: undefined,
providedLibraryMetadata: undefined
}], "Sapui5Resolver#constructor should be called with expected args");
});
Expand Down Expand Up @@ -375,6 +377,7 @@ test.serial("enrichProjectGraph: With versionOverride containing snapshot versio
cacheMode: undefined,
cwd: dependencyTree.path,
version: "1.99.9-SNAPSHOT",
ui5HomeDir: undefined,
providedLibraryMetadata: undefined
}], "Sapui5Resolver#constructor should be called with expected args");
});
Expand Down Expand Up @@ -431,6 +434,7 @@ test.serial("enrichProjectGraph: With versionOverride containing latest-snapshot
cacheMode: undefined,
cwd: dependencyTree.path,
version: "1.99.9-SNAPSHOT",
ui5HomeDir: undefined,
providedLibraryMetadata: undefined
}], "Sapui5Resolver#constructor should be called with expected args");
});
Expand Down Expand Up @@ -587,6 +591,7 @@ test.serial("enrichProjectGraph should resolve framework project with version an
cacheMode: undefined,
cwd: dependencyTree.path,
version: "1.2.3",
ui5HomeDir: undefined,
providedLibraryMetadata: undefined
}], "Sapui5Resolver#constructor should be called with expected args");
});
Expand Down Expand Up @@ -685,6 +690,7 @@ test.serial("enrichProjectGraph should resolve framework project " +
cacheMode: undefined,
cwd: dependencyTree.path,
version: "1.99.9",
ui5HomeDir: undefined,
providedLibraryMetadata: undefined
}], "Sapui5Resolver#constructor should be called with expected args");
});
Expand Down Expand Up @@ -949,6 +955,7 @@ test.serial("enrichProjectGraph should use framework library metadata from works
cacheMode: undefined,
cwd: dependencyTree.path,
version: "1.111.1",
ui5HomeDir: undefined,
providedLibraryMetadata: workspaceFrameworkLibraryMetadata
}], "Sapui5Resolver#constructor should be called with expected args");
t.is(Sapui5ResolverStub.getCall(0).args[0].providedLibraryMetadata, workspaceFrameworkLibraryMetadata);
Expand Down Expand Up @@ -1006,6 +1013,7 @@ test.serial("enrichProjectGraph should allow omitting framework version in case
t.deepEqual(Sapui5ResolverStub.getCall(0).args, [{
cacheMode: undefined,
cwd: dependencyTree.path,
ui5HomeDir: undefined,
version: undefined,
providedLibraryMetadata: workspaceFrameworkLibraryMetadata
}], "Sapui5Resolver#constructor should be called with expected args");
Expand Down
3 changes: 2 additions & 1 deletion test/lib/ui5framework/Sapui5MavenSnapshotResolver.js
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,8 @@ test.serial("_resolveSnapshotEndpointUrl: Maven fallback with config update", as
t.is(configFromFile.callCount, 1, "Configuration has been read once");
t.is(configToFile.callCount, 1, "Configuration has been written once");
t.deepEqual(configToFile.firstCall.firstArg.toJson(), {
mavenSnapshotEndpointUrl: "maven-url"
mavenSnapshotEndpointUrl: "maven-url",
ui5DataDir: undefined
}, "Correct configuration has been written");
});

Expand Down

0 comments on commit b3759ff

Please sign in to comment.