Skip to content

Commit

Permalink
[INTERNAL] Fix unit/coverage setup on Node 20 and adapt CI matrix
Browse files Browse the repository at this point in the history
AVA's nodeArguments option doesn't seem to work with loaders on Node 20.
One solution is to disable worker threads to use child processes instead.
This should also stabilize test execution, especially when tests also
spawn new worker threads, which mainly appeared in ui5-builder.

See: SAP/ui5-server#602
JIRA: CPOUI5FOUNDATION-612
  • Loading branch information
matz3 committed Jul 13, 2023
1 parent 557cb36 commit 281813e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ strategy:
node_version: 18.x
linux_node_current:
imageName: 'ubuntu-22.04'
node_version: 19.x
node_version: 20.x
mac_node_current:
imageName: 'macos-12'
node_version: 19.x
node_version: 20.x
windows_node_current:
imageName: 'windows-2022'
node_version: 19.x
node_version: 20.x

pool:
vmImage: $(imageName)
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@
"nodeArguments": [
"--loader=esmock",
"--no-warnings"
]
],
"workerThreads": false
},
"nyc": {
"reporter": [
Expand Down

0 comments on commit 281813e

Please sign in to comment.