Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add manual test case and meaningful ids #725

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

marufrasully
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: d7603e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext Patch
vscode-ui5-language-assistant Patch
@ui5-language-assistant/xml-views-quick-fix Patch
@ui5-language-assistant/language-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

sonarcloud bot commented Aug 22, 2024

Copy link
Contributor

@vadson71 vadson71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Didn't test them locally

@marufrasully marufrasully merged commit 491c5f9 into master Aug 22, 2024
9 checks passed
@marufrasully marufrasully deleted the fix/manual-test-meaningful-ids branch August 22, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants