Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warning text correction #712

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: warning text correction #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/nice-news-talk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@ui5-language-assistant/fe": patch
"vscode-ui5-language-assistant": patch
"@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext": patch
---

Warning text correction
2 changes: 1 addition & 1 deletion packages/fe/src/i18n/i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"UNKNOWN_PATH": "Unknown path: \"{{value}}\"",
"INVALID_PROPERTY_PATH_MULTIPLE_1_TO_MANY": "Invalid property path value. Multiple 1:many association segments not allowed",

"ENTITY_SET_OR_CONTEXT_PATH_IS_MISSING_IN_MANIFEST": "Path cannot be identified: use absolute path or define contextPath",
"ENTITY_SET_OR_CONTEXT_PATH_IS_MISSING_IN_MANIFEST": "The path cannot be identified. Use an absolute path or define the contextPath",
"EMPTY_CONTEXT_PATH_IN_MANIFEST": "ContextPath in manifest is empty. Attribute value completion and diagnostics are disabled",
"RELATIVE_CONTEXT_PATH_IN_MANIFEST": "ContextPath in manifest \"{{value}}\" must be absolute. Attribute value completion and diagnostics are disabled",
"UNKNOWN_CONTEXT_PATH_IN_MANIFEST": "Unknown contextPath in manifest \"{{value}}\". Attribute value completion and diagnostics are disabled",
Expand Down
6 changes: 3 additions & 3 deletions packages/fe/test/unit/services/diagnostics/validators/missing-entity-set.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ describe("missing entitySet validation", () => {
}
);
expect(result.map((item) => issueToSnapshot(item))).toStrictEqual([
"kind: MissingEntitySet; text: Path cannot be identified: use absolute path or define contextPath; severity:warn; offset:344-354",
"kind: MissingEntitySet; text: The path cannot be identified. Use an absolute path or define the contextPath; severity:warn; offset:344-354",
]);
});

Expand All @@ -87,7 +87,7 @@ describe("missing entitySet validation", () => {
(c) => ({ ...c, manifestDetails: undefined } as any)
);
expect(result.map((item) => issueToSnapshot(item))).toStrictEqual([
"kind: MissingEntitySet; text: Path cannot be identified: use absolute path or define contextPath; severity:warn; offset:344-349",
"kind: MissingEntitySet; text: The path cannot be identified. Use an absolute path or define the contextPath; severity:warn; offset:344-349",
]);
});

Expand All @@ -103,7 +103,7 @@ describe("missing entitySet validation", () => {
}
);
expect(result.map((item) => issueToSnapshot(item))).toStrictEqual([
"kind: MissingEntitySet; text: Path cannot be identified: use absolute path or define contextPath; severity:warn; offset:344-349",
"kind: MissingEntitySet; text: The path cannot be identified. Use an absolute path or define the contextPath; severity:warn; offset:344-349",
]);
});
});
Expand Down
Loading