fix: relax diagnostic for special property #708
Conversation
🦋 Changeset detectedLatest commit: f3144a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
| if (!usedRequiredEl && altTypes) { | ||
| // some property e.g `tooltip` can be used with both `aggregation binding info` or `property binding info`. Therefore `altTypes` is defined in design time. | ||
| // if `altTypes` is present, check if any element is used. This is a very broad check to avoid false diagnostic. | ||
| usedRequiredEl = element.elements[0]; |
There was a problem hiding this comment.
Does elements array always contain at least one element?
Maybe better here just exit the validation function with empty result?
There was a problem hiding this comment.
the exception is to check if there is at least one element present from either aggregation property binding or property binding info. If that element is not present, we still want to show diagnostic for mandatory property.
Issue: #707
Description
Some property e.g
tooltipcan be used with bothaggregation binding infoorproperty binding info. Aggregation binding in this case requires mandatory property e.gpathwhere property binding requires no mandatory property. Application user can decide to use eitheraggregation binding infoorproperty binding info. This PR relax diagnostics check. If there is any element used, diagnostic for mandatory property is not checked.