Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance check for binding expression #653

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Conversation

marufrasully
Copy link
Contributor

@marufrasully marufrasully commented Sep 18, 2023

link to issue: #652

Relax check for isBindingAllowed
Support ui5object a special marker

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023

🦋 Changeset detected

Latest commit: ef49bc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
vscode-ui5-language-assistant Patch
@ui5-language-assistant/binding-parser Patch
@ui5-language-assistant/binding Patch
@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext Patch
@ui5-language-assistant/language-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

81.1% 81.1% Coverage
1.1% 1.1% Duplication

@marufrasully marufrasully merged commit 1a1115e into master Sep 20, 2023
10 checks passed
@marufrasully marufrasully deleted the fix/issue-652 branch September 20, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants