fix: use json api #626
fix: use json api #626
Conversation
🦋 Changeset detectedLatest commit: dd60fd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| kind: "string", | ||
| default: { | ||
| values: [ | ||
| "sap.ui.model.BindingMode.Default", |
There was a problem hiding this comment.
We have this information in the semantic model, I don't think we should hard code it here.
| export interface Dependents { | ||
| name: BindingInfoName; | ||
| type: PropertyType[]; | ||
| } | ||
| export interface PropertyType { | ||
| kind: TypeKind; | ||
| kind: string; | ||
| default?: { |
There was a problem hiding this comment.
default seems a bit misleading here. It's a list of "all" possible values, not the one that would be used in case there is no other value.
| PropertyType, | ||
| TypeKind, | ||
| } from "../types"; | ||
| const buildType = (property: UI5TypedefProp): PropertyType[] => { |
There was a problem hiding this comment.
This part seems to be essentially the same - It's still is hardcoded against a specific list of properties.
packages/semantic-model/src/api.ts
Outdated
| @@ -41,6 +41,7 @@ export function generate({ | |||
| model.version = version; | |||
| model.isFallback = isFallback; | |||
| model.isIncorrectVersion = isIncorrectVersion; | |||
| addTypedefType(model); | |||
There was a problem hiding this comment.
Why couldn't we use similar logic to class properties?
| @@ -298,3 +298,88 @@ const typesToIgnore: Record<string, undefined> = { | |||
| function ignoreType(typeName: string): boolean { | |||
| return has(typesToIgnore, typeName); | |||
| } | |||
|
|
|||
| export function resolveTypeDefPropertyType( | |||
There was a problem hiding this comment.
This looks very similar to resolveType. We should have only one function for resolving types unless there is a good reason to have multiple. As far as I know all type strings should have the same structure and should be processed the same way.
| @@ -78,6 +78,7 @@ export interface UI5Namespace extends BaseUI5Node { | |||
| export interface UI5Typedef extends BaseUI5Node { | |||
| kind: "UI5Typedef"; | |||
| properties: UI5TypedefProp[]; | |||
| symbolProperties: (Ui5Property | ObjProperty)[]; | |||
There was a problem hiding this comment.
We should avoid adding temporary data into the model, because it adds additional clutter and confusion which of the similar properties should be used.
|
SonarCloud Quality Gate failed.
|
No description provided.