[PoC] ResourcePool: Add option to prefer analyzing a resource's source content #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stic
Stop analyzing debug-resources if they correspond to a non-debug
resource.
Only analyze the non-debug resource and copy any dependency information
to the corresponding debug-resource.
While this might not be the best approach given that analyzing the
source ("debug") version of a resource might result in finding more
dependencies (i.e. those mangled during minification), this change
ensures that we generate the same resources.json, independently
from the order of debug and non-debug resources supplied to the
resourceListCreator processor.
Resolves SAP/ui5-tooling#274
RandomByte
changed the base branch from
master
to
resources-json-generation-consistency
RandomByte
changed the title
This reverts commit 6bbc8e9.
…e content Possible follow up of #551 to improve dependency analysis. JSModuleAnalyzer has trouble detecting some dependencies in minified code if they have been "mangled". E.g. in case jQuery is not named jQuery anymore. This change solves that by trying to retrieve the debug ("source") content of a resource to analyze that instead of the minified version. However, integrating this on the ResourcePool level is not ideal and a more general solution to this problem should be preferred. Therefore this PR should only act as an illustration of the discussions and thoughts. Currently it should not be merged.
RandomByte
force-pushed
the
resources-pool-allow-analysis-of-resources-source
branch
from
e3c1247
to
136c879
Compare
Base automatically changed from
resources-json-generation-consistency
to
master
November 30, 2020 14:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #551 to improve dependency analysis.
JSModuleAnalyzer has trouble detecting some dependencies in minified code if they have been "mangled". E.g. in case jQuery is not named jQuery anymore.
This change solves that by trying to retrieve the debug ("source") content of a resource to analyze that instead of the minified version.
However, integrating this on the ResourcePool level is not ideal and a more general solution to this problem should be preferred.
Therefore this PR should only act as an illustration of the discussions and thoughts. Currently it should not be merged.