Skip to content

Commit

Permalink
Merge pull request #143 from SAP/docs/broken-links
Browse files Browse the repository at this point in the history
docs: fix broken link, align local references
  • Loading branch information
lechnerc77 authored Jun 19, 2024
2 parents 105b8e7 + 1ccab1c commit 8bfd8b0
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion migration-guide/data-sources/space.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ Gets information on a Cloud Foundry space.
| Attribute name | SAP Cloud Foundry Provider (new)| Community Cloud Foundry Provider (old) | Description |
| --- | --- | --- | --- |
| org_name | πŸ”΄ | 🟒 | - |
| org | πŸ”΅ | 🟒 | Space can now be queried only by `org` GUID and not by `org_name`. If one knows org_name and not org GUID, one can obtain the id value from [`cloudfoundry_org`](https://github.com/SAP/terraform-provider-cloudfoundry/blob/main/docs/data-sources/org.md) resource by specifying `name`. |
| org | πŸ”΅ | 🟒 | Space can now be queried only by `org` GUID and not by `org_name`. If one knows org_name and not org GUID, one can obtain the id value from [`cloudfoundry_org`](./org.md) resource by specifying `name`. |
| allow_ssh | 🟠 | πŸ”΄ | - |
| isolation_segment | 🟠 | πŸ”΄ | - |
2 changes: 1 addition & 1 deletion migration-guide/data-sources/user.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ Gets information on Cloud Foundry users with a given username.
| Attribute name | SAP Cloud Foundry Provider (new)| Community Cloud Foundry Provider (old) | Description |
| --- | --- | --- | --- |
| org_id | πŸ”΄ | 🟒 | For fetching specific user under a particular org in current provider, one can set the `org` attribute in [`cloudfoundry_users`](https://github.com/SAP/terraform-provider-cloudfoundry/blob/main/docs/data-sources/users.md) resource and then from `users` attribute output, filter the user with `username` desired. |
| org_id | πŸ”΄ | 🟒 | For fetching specific user under a particular org in current provider, one can set the `org` attribute in [`cloudfoundry_user`](./user.md) resource and then from `users` attribute output, filter the user with `username` desired. |
| users | 🟠 | πŸ”΄ | - |
| id | πŸ”΄ | 🟠 | The current provider returns multiple users if available with same user name in the `users` attribute unlike the community provider. Therefore the id is present in the respective user resources in `users` output. |
2 changes: 1 addition & 1 deletion migration-guide/resources/app.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Provides a Cloud Foundry resource to manage applications.
| enable_ssh | πŸ”΄ | 🟒 | It can be enabled on a space level. For further details, refer [here](https://docs.cloudfoundry.org/devguide/deploy-apps/ssh-apps.html#config-ssh-access-apps). |
| stopped | πŸ”΄ | 🟒 | `stopped` attribute functionality can be achieved by setting `instances` to 0. |
| routes.route | 🟒 | 🟒 | In the new provider, FQDN needs to be specified instead of the route GUID in the community provider. Route resource is automatically created if not present. |
| routes.port | πŸ”΄ | 🟒 | Not present in V3 manifest schema. Can be set in `port` attribute of [`cloudfoundry_route`](https://github.com/SAP/terraform-provider-cloudfoundry/blob/main/docs/resources/route.md) resource. |
| routes.port | πŸ”΄ | 🟒 | Not present in V3 manifest schema. Can be set in `port` attribute of [`cloudfoundry_route`]( ./route.md) resource. |
| routes.protocol | 🟒 | πŸ”΄ | - |
| health_check_interval | 🟒 | πŸ”΄ | - |
| log_rate_limit_per_second | 🟒 | πŸ”΄ | - |
Expand Down
2 changes: 1 addition & 1 deletion migration-guide/resources/org.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ Provides a Cloud Foundry resource for managing Cloud Foundry organizations
| Attribute name | SAP Cloud Foundry Provider (new)| Community Cloud Foundry Provider (old) | Description |
| --- | --- | --- | --- |
| quota | 🟠| 🟒 | One cannot set quota as it is a read-only attribute in the current provider. For setting quota use resource [`cloudfoundry_org_quota`](https://github.com/SAP/terraform-provider-cloudfoundry/blob/main/docs/resources/org_quota.md). |
| quota | 🟠| 🟒 | One cannot set quota as it is a read-only attribute in the current provider. For setting quota use resource [`cloudfoundry_org_quota`](./org_quota.md). |
| suspended | 🟒 | πŸ”΄ | - |
| delete_recursive_allowed | πŸ”΄ | 🟒 | V3 API by default follows recursive deletion. |
2 changes: 1 addition & 1 deletion migration-guide/resources/service_credential_binding.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Provides a resource for managing service credential bindings in Cloud Foundry. C
| Attribute name | SAP Cloud Foundry Provider (new)| Community Cloud Foundry Provider (old) | Description |
| --- | --- | --- | --- |
| credentials | πŸ”΄ | 🟠 | Attribute not returned as part of V3 API resource. However, it is obtainable from `credential_binding` attribute of data source [`cloudfoundry_service_credential_binding`](https://github.com/SAP/terraform-provider-cloudfoundry/blob/main/docs/data-sources/service_credential_binding.md). |
| credentials | πŸ”΄ | 🟠 | Attribute not returned as part of V3 API resource. However, it is obtainable from `credential_binding` attribute of data source [`cloudfoundry_service_credential_binding`](../data-sources/service_credential_binding.md). |
| type | πŸ”΅ | πŸ”΄ | Need to specify whether binding is of type app or key. |
| labels | 🟒 | πŸ”΄ | - |
| annotations | 🟒 | πŸ”΄ | - |
Expand Down
6 changes: 3 additions & 3 deletions migration-guide/resources/space.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Provides a Cloud Foundry resource for managing Cloud Foundry spaces within organ
| Attribute name | SAP Cloud Foundry Provider (new)| Community Cloud Foundry Provider (old) | Description |
| --- | --- | --- | --- |
| quota | 🟠 | 🟒 | One cannot set quota as it is a read-only attribute in the current provider. For setting quota use resource [`cloudfoundry_space_quota`](https://github.com/SAP/terraform-provider-cloudfoundry/blob/main/docs/resources/space_quota.md). |
| asgs| πŸ”΄ | 🟒 | Security groups not present in space resource as part of V3 API Spec. One can however set it with `running_spaces` attribute from resource [`cloudfoundry_security_group`](https://github.com/SAP/terraform-provider-cloudfoundry/blob/main/docs/resources/security_group.md). |
| staging_asgs| πŸ”΄ | 🟒 | Staging Security groups not present in space resource as part of V3 API Spec. One can however set it with `staging_spaces` attribute from resource [`cloudfoundry_security_group`](https://github.com/SAP/terraform-provider-cloudfoundry/blob/main/docs/resources/security_group.md). |
| quota | 🟠 | 🟒 | One cannot set quota as it is a read-only attribute in the current provider. For setting quota use resource [`cloudfoundry_space_quota`](./space_quota.md). |
| asgs| πŸ”΄ | 🟒 | Security groups not present in space resource as part of V3 API Spec. One can however set it with `running_spaces` attribute from resource [`cloudfoundry_security_group`](./security_group.md). |
| staging_asgs| πŸ”΄ | 🟒 | Staging Security groups not present in space resource as part of V3 API Spec. One can however set it with `staging_spaces` attribute from resource [`cloudfoundry_security_group`](./security_group.md). |
| delete_recursive_allowed | πŸ”΄ | 🟒 | V3 API by default follows recursive deletion. |

0 comments on commit 8bfd8b0

Please sign in to comment.