fix: (CXSPA-7992) Store, MyPreferredStoreComponent 'view hours button' icon contrast #19379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spartacus
|
||||||||||||||||||||||||
| Project |
spartacus
|
| Run status |
|
| Run duration | 04m 32s |
| Commit |
|
| Committer | Stanislav Sukhanov |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Pio-Bar
requested changes
Oct 10, 2024
| occCartNameAndDescriptionInHttpRequestBody: false, | ||
| cmsBottomHeaderSlotUsingFlexStyles: false, | ||
| useSiteThemeService: false, | ||
| useSiteThemeService: true, |
There was a problem hiding this comment.
Should we leave this toggle on?
There was a problem hiding this comment.
Hi @Pio-Bar. Thanks for pointing it out. Fixed.
StanislavSukhanov
force-pushed
the
feature/CXSPA-7992-button-icon-doesnt-meet-a-colour-contrast
branch
from
ca0dd62
to
cffabc3
Compare
Merge Checks Failed |
Pio-Bar
previously approved these changes
Oct 11, 2024
Zeyber
previously approved these changes
Oct 15, 2024
StanislavSukhanov
dismissed stale reviews from Zeyber and Pio-Bar
via
bfbcb5b
StanislavSukhanov
force-pushed
the
feature/CXSPA-7992-button-icon-doesnt-meet-a-colour-contrast
branch
from
ffcc4c7
to
bfbcb5b
Compare
Merge Checks Failed |
1 similar comment
Merge Checks Failed |
developpeurweb
previously approved these changes
Oct 16, 2024
…' icon contrast * fixed an opacity of button's icon to meet a colour contrast requirement. * closes https://jira.tools.sap/browse/CXSPA-7992
…' icon contrast * fixed an opacity of button's icon to meet a colour contrast requirement. * closes https://jira.tools.sap/browse/CXSPA-7992
StanislavSukhanov
force-pushed
the
feature/CXSPA-7992-button-icon-doesnt-meet-a-colour-contrast
branch
from
c31196d
to
f26b49b
Compare
…t-a-colour-contrast
Zeyber
approved these changes
Oct 17, 2024
StanislavSukhanov
deleted the
feature/CXSPA-7992-button-icon-doesnt-meet-a-colour-contrast
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed an opacity of button's icon to meet a colour contrast requirement.
closes https://jira.tools.sap/browse/CXSPA-7992