Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(SSR e2e): Validate http port 4000 is not used by other process, before running tests #19337

Merged
merged 15 commits into from
Oct 4, 2024
Merged

test(SSR e2e): Validate http port 4000 is not used by other process, before running tests #19337

merged 15 commits into from
Oct 4, 2024

Commits on Oct 3, 2024

  1. test(SSR e2e): re-enable test "should receive response with status 50… 

    …0 if HTTP error occurred when calling other than cms/pages API URL"
    @Platonn
    Platonn committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ee654c3 View commit details
    Browse the repository at this point in the history

  2. empty commit

    @Platonn
    Platonn committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    e6e1e3e View commit details
    Browse the repository at this point in the history

  3. chore: console.warn instead of throwing Error while validating JSONs … 

    …in logs. And provide more context about the problem with parsing
    @Platonn
    Platonn committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    489ce2f View commit details
    Browse the repository at this point in the history

  4. chore: fix SonarQube complain

    @Platonn
    Platonn committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    c7d8e7f View commit details
    Browse the repository at this point in the history

  5. refactor: reuse surroundingLinesRadius variable

    @Platonn
    Platonn committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5d61fb0 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. chore: validate the build ouptut file main.js for using prod mode and… 

    … proxy backend before running tests. Previously we were checking the app's behavior in the runtime of tests, checking its symptoms of running in dev mode.
    @Platonn
    Platonn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f58ec4f View commit details
    Browse the repository at this point in the history

  2. Add license header

    @github-actions
    github-actions[bot] committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a1c0502 View commit details
    Browse the repository at this point in the history

  3. refactor: highlight to yellow the whole advice

    @Platonn
    Platonn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a1d902e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/CXSPA-8570' of github.com:SAP/spartacus into fe… 

    …ature/CXSPA-8570
    @Platonn
    Platonn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    558649d View commit details
    Browse the repository at this point in the history

  5. doc: fix jsdoc

    @Platonn
    Platonn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2769dc9 View commit details
    Browse the repository at this point in the history

  6. revert un-skipping one test. as it's not in the scope of this PR

    @Platonn
    Platonn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    5605f5f View commit details
    Browse the repository at this point in the history

  7. refactor: remove variable BUILD_COMMAND

    @Platonn
    Platonn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    602eb13 View commit details
    Browse the repository at this point in the history

  8. refactor: improve colors of message

    @Platonn
    Platonn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    6158e4b View commit details
    Browse the repository at this point in the history

  9. test(SSR e2e): before running tests, check if some process listens on… 

    … the port 4000. If yes, avoid running errors and give advice on how to kill that process
    @Platonn
    Platonn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a865c49 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'develop' of github.com:SAP/spartacus into feature/CXSPA… 

    …-8587
    @Platonn
    Platonn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c5a41e3 View commit details
    Browse the repository at this point in the history