Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Redundant styles in styles.css file loaded in the browser (CXSPA-8211) #19314

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

kimhw0630
Copy link
Contributor

Closes: https://jira.tools.sap/browse/CXSPA-8211

Removed the import of the theme file from all files except the core.

@kimhw0630 kimhw0630 requested a review from a team as a code owner October 1, 2024 12:36
@github-actions github-actions bot marked this pull request as draft October 1, 2024 12:37
@kimhw0630 kimhw0630 marked this pull request as ready for review October 1, 2024 13:29
Copy link

cypress bot commented Oct 1, 2024

spartacus    Run #45105

Run Properties:  status check passed Passed #45105  •  git commit 1f3ba0d841 ℹ️: Merge a29e97c06ffcd62555337ed0088d9256b4bb47bf into 7751dc1569e3291716465092a632...
Project spartacus
Branch Review fix/XSPA-8211
Run status status check passed Passed #45105
Run duration 04m 35s
Commit git commit 1f3ba0d841 ℹ️: Merge a29e97c06ffcd62555337ed0088d9256b4bb47bf into 7751dc1569e3291716465092a632...
Committer Hak Woo Kim
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft October 2, 2024 14:03
@kimhw0630 kimhw0630 marked this pull request as ready for review October 2, 2024 14:34
@kimhw0630 kimhw0630 merged commit bc29bb5 into develop Oct 2, 2024
28 checks passed
@kimhw0630 kimhw0630 deleted the fix/XSPA-8211 branch October 2, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants