CXSPA-8201: code refactor #19145
Merged
CXSPA-8201: code refactor #19145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
fix/CXSPA-8201
|
| Run status |
|
| Run duration | 03m 33s |
| Commit |
|
| Committer | Scar Ai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
121
|
| View all changes introduced in this branch ↗︎ | |
i53577
previously approved these changes
Aug 21, 2024
Zeyber
approved these changes
Aug 21, 2024
meeque
reviewed
Aug 23, 2024
|
|
||
| export interface CaptchaRenderer { | ||
| /** | ||
| * Renders captcha widget |
There was a problem hiding this comment.
Could we also add something like:
Implementations must use secure DOM manipulation methods to protect against XSS.
meeque
reviewed
Aug 23, 2024
| * Renders captcha widget | ||
| * | ||
| * @RenderParams parameters required by a provider, includes html element to append CAPTCHA UI element. | ||
| * @returns Observable for the key returned by a provider once user validated |
There was a problem hiding this comment.
Why is it called key here? It's called token everywhere else. Or are these different things?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATT.
Small code refactor for feature CAPTCHA