fix: (CXSPA-8012) - Zoom dialog close on escape #19135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Checks Failed |
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-8012
|
| Run status |
|
| Run duration | 04m 30s |
| Commit |
|
| Committer | PioBar |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
121
|
| View all changes introduced in this branch ↗︎ | |
Zeyber
requested changes
Aug 20, 2024
| *cxFeature="'a11yZoomDialogCloseOnEsc'" | ||
| class="cx-image-zoom-dialog" | ||
| role="dialog" | ||
| (esc)="close('Escape clicked')" |
There was a problem hiding this comment.
It looks like only the keybinding here has been added. I wouldn't consider this a breaking change.
There was a problem hiding this comment.
Feature flag removed
Zeyber
approved these changes
Aug 23, 2024
developpeurweb
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CXSPA-8012
The product image zoom dialog should now close after pressing the esc key.