Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXSPA 7627 reschedule service order #19114

Merged
merged 57 commits into from
Aug 20, 2024
Merged

Conversation

suprishi
Copy link
Member

@suprishi suprishi commented Aug 7, 2024

https://jira.tools.sap/browse/CXSPA-7627

The following is a checklist for new epics or features acceptance for Spartacus, based on our Definition of Done document

General

  • Epic has been tested on a production-like server using Spartacus installation script
  • Epic has been tested in all supported browsers and devices (Check list on DoD page)
  • Epic has sufficient end to end (cypress) test coverage
  • Schematics code deprecations have been provided and tested
  • Epic complies with Security best practices
  • Epic complies with Accessibility best practices
  • Epic CSS supports directionality (if required)
  • Epic code scans have been conducted Compliance scans for branches
  • Epic renders successfully in SSR

Audits/reviews

  • Architecture review of the epic
  • Security and threat modeling audit/review from the Security team
  • Accessibility audit/review from the UX team

New Library

If your epic will be introduced or introduces a new library:

  • Library provides schematics to install the library
  • Library modules can be lazy loaded appropriately
  • Library has been tested for a customer using Spartacus installation script

Sample data

If the new feature requires new or updated sample data for a specific Commerce backend version:

  • Sample data has been added to the sampledata repo and merged to the next version to be released
  • New sample data has been loaded and tested on a dev server
  • New sample data has been loaded and tested in our CI server

Documentation

  • Documentation input is provided for it to be published on the doc site.

@suprishi suprishi requested a review from a team as a code owner August 7, 2024 05:34
@github-actions github-actions bot marked this pull request as draft August 7, 2024 05:34
@pawelfras pawelfras mentioned this pull request Aug 19, 2024
19 tasks
pawelfras
pawelfras previously approved these changes Aug 19, 2024
Copy link
Contributor

@pawelfras pawelfras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise.

@pawelfras pawelfras marked this pull request as ready for review August 19, 2024 13:44
Copy link

cypress bot commented Aug 19, 2024



Test summary

121 0 2 0Flakiness 3


Run details

Project spartacus
Status Passed
Commit e2d4c48 ℹ️
Started Aug 20, 2024 7:53 AM
Ended Aug 20, 2024 7:56 AM
Duration 03:36 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️


Flakiness

cypress/e2e/ssr/pages.core-e2e.cy.ts Flakiness
1 SSR > should render homepage
2 SSR > should render PLP
3 SSR > should render PDP

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@suprishi suprishi marked this pull request as ready for review August 20, 2024 07:20
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft August 20, 2024 07:30
@pawelfras pawelfras marked this pull request as ready for review August 20, 2024 07:42
@suprishi suprishi merged commit 7023289 into develop Aug 20, 2024
28 checks passed
@suprishi suprishi deleted the CXSPA-7627-reschedule-service-order branch August 20, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants