fix: (CXSPA-944) - Repeated page title fix #19035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||||||||||
Zeyber
requested changes
Jul 11, 2024
projects/storefrontlib/cms-components/navigation/breadcrumb/breadcrumb.component.ts
Outdated
Show resolved
Hide resolved
projects/storefrontlib/cms-components/navigation/breadcrumb/breadcrumb.component.ts
Outdated
Show resolved
Hide resolved
Zeyber
requested changes
Jul 12, 2024
projects/storefrontlib/cms-components/navigation/breadcrumb/breadcrumb.component.ts
Outdated
Show resolved
Hide resolved
Zeyber
requested changes
Jul 15, 2024
projects/storefrontlib/cms-components/navigation/breadcrumb/breadcrumb.component.ts
Outdated
Show resolved
Hide resolved
Merge Checks Failed |
Zeyber
requested changes
Jul 15, 2024
| @@ -36,6 +57,14 @@ export class BreadcrumbComponent extends PageTitleComponent implements OnInit { | |||
| ngOnInit(): void { | |||
| super.ngOnInit(); | |||
| this.setCrumbs(); | |||
| if (this.featureConfigService.isEnabled('a11yRepeatedPageTitleFix')) { | |||
Zeyber
previously approved these changes
Jul 16, 2024
developpeurweb
previously approved these changes
Aug 8, 2024
Zeyber
previously approved these changes
Aug 13, 2024
Merge Checks Failed |
Zeyber
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CXSPA-944
The title was read twice due to the focus returning to the body element and reading both the page title and breadcrumbs component's aria-live. We can conditionally toggle the aria-live area to avoid the repetition.