fix: wrong usage of attribute required (#19005)

SAP · Jul 10, 2024 · fdc59fc · fdc59fc
1 parent 51eab1d
commit fdc59fc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/...ibute/types/numeric-input-field/configurator-attribute-numeric-input-field.component.html b/...ibute/types/numeric-input-field/configurator-attribute-numeric-input-field.component.html
@@ -17,7 +17,7 @@
  : createAttributeUiKey('label', attribute.name)
  "
  attr.role="{{ attribute.dataType }}"
- attr.required="{{ attribute.required }}"
+ [attr.required]="attribute.required === true ? 'required' : null"
  (change)="onChange()"
  maxlength="{{ attribute.maxlength }}"
  [attr.aria-label]="getAriaLabelComplete()"

diff --git a/...omponents/attribute/types/radio-button/configurator-attribute-radio-button.component.html b/...omponents/attribute/types/radio-button/configurator-attribute-radio-button.component.html
@@ -21,7 +21,7 @@
  type="radio"
  formcontrolname="attributeRadioButtonForm"
  [formControl]="attributeRadioButtonForm"
- [attr.required]="attribute.required"
+ [attr.required]="attribute.required === true ? 'required' : null"
  [value]="value.valueCode"
  name="{{ createAttributeIdForConfigurator(attribute) }}"
  attr.name="{{ createAttributeIdForConfigurator(attribute) }}"

diff --git a/...types/single-selection-image/configurator-attribute-single-selection-image.component.html b/...types/single-selection-image/configurator-attribute-single-selection-image.component.html
@@ -24,7 +24,7 @@
  [value]="value.valueCode"
  name="{{ createAttributeIdForConfigurator(attribute) }}"
  attr.name="{{ createAttributeIdForConfigurator(attribute) }}"
- [attr.required]="attribute.required"
+ [attr.required]="attribute.required === true ? 'required' : null"
  [attr.checked]="
  attributeRadioButtonForm.value === value.valueCode ? 'checked' : null
  "
@@ -96,7 +96,7 @@
  [value]="value.valueCode"
  name="{{ createAttributeIdForConfigurator(attribute) }}"
  attr.name="{{ createAttributeIdForConfigurator(attribute) }}"
- [attr.required]="attribute.required"
+ [attr.required]="attribute.required === true ? 'required' : null"
  [attr.checked]="
  attributeRadioButtonForm.value === value.valueCode
  ? 'checked'