Skip to content

Commit

Permalink
CXCDS-12024 fix translation schematics (#19012)
Browse files Browse the repository at this point in the history
Co-authored-by: Artur Lasocha <[email protected]>
Co-authored-by: Konrad Dzikowski <[email protected]>
  • Loading branch information
3 people authored Jul 11, 2024
1 parent 77ba8c2 commit 166522a
Show file tree
Hide file tree
Showing 40 changed files with 101 additions and 13 deletions.
1 change: 1 addition & 0 deletions core-libs/setup/tsconfig.spec.json
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/asm/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/cart/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/checkout/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/customer-ticketing/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/order/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/organization/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/pdf-invoices/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/pickup-in-store/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -562,6 +562,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/product-configurator/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/product/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/qualtrics/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/quote/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -562,6 +562,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/smartedit/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/storefinder/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/tracking/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/user/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions integration-libs/cdc/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions integration-libs/cdp/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
6 changes: 6 additions & 0 deletions integration-libs/cds/assets/ng-package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"$schema": "../../../node_modules/ng-packagr/ng-package.schema.json",
"lib": {
"entryFile": "./public_api.ts"
}
}
File renamed without changes.
6 changes: 5 additions & 1 deletion integration-libs/cds/public_api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,8 @@ export * from './src/cds.module';
export * from './src/config/index';
export * from './src/merchandising/index';
export * from './src/profiletag/index';
export * from './assets/index';

/**
* @deprecated Use @spartacus/cds/assets instead.
*/
export * from './src/assets/index';
18 changes: 18 additions & 0 deletions integration-libs/cds/src/assets/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
/*
* SPDX-FileCopyrightText: 2024 SAP Spartacus team <[email protected]>
*
* SPDX-License-Identifier: Apache-2.0
*/

import { TranslationChunksConfig, TranslationResources } from '@spartacus/core';
import {
cdsTranslations as originalCdsTranslations,
cdsTranslationChunksConfig as originalCdsTranslationChunksConfig,
} from '@spartacus/cds/assets';

/** @deprecated Use @spartacus/cds/assets instead */
export const cdsTranslations: TranslationResources = originalCdsTranslations;

/** @deprecated Use @spartacus/cds/assets instead */
export const cdsTranslationChunksConfig: TranslationChunksConfig =
originalCdsTranslationChunksConfig;
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,21 @@
exports[`Spartacus CDS schematics: ng-add CDS feature with Profile tag configured general setup should create the feature module 1`] = `
"import { NgModule } from '@angular/core';
import { CdsConfig, CdsModule } from "@spartacus/cds";
import { provideConfig } from "@spartacus/core";
import { cdsTranslationChunksConfig, cdsTranslations } from "@spartacus/cds/assets";
import { I18nConfig, provideConfig } from "@spartacus/core";
@NgModule({
declarations: [],
imports: [
CdsModule.forRoot()
],
providers: [provideConfig(<CdsConfig>{
providers: [provideConfig(<I18nConfig>{
i18n: {
resources: cdsTranslations,
chunks: cdsTranslationChunksConfig,
},
}),
provideConfig(<CdsConfig>{
cds: {
tenant: 'my-tenant',
baseUrl: 'my-base-url.com',
Expand Down Expand Up @@ -42,14 +49,21 @@ export class CdsFeatureModule { }
exports[`Spartacus CDS schematics: ng-add CDS feature without Profile tag general setup should create the feature module 1`] = `
"import { NgModule } from '@angular/core';
import { CdsConfig, CdsModule } from "@spartacus/cds";
import { provideConfig } from "@spartacus/core";
import { cdsTranslationChunksConfig, cdsTranslations } from "@spartacus/cds/assets";
import { I18nConfig, provideConfig } from "@spartacus/core";
@NgModule({
declarations: [],
imports: [
CdsModule.forRoot()
],
providers: [provideConfig(<CdsConfig>{
providers: [provideConfig(<I18nConfig>{
i18n: {
resources: cdsTranslations,
chunks: cdsTranslationChunksConfig,
},
}),
provideConfig(<CdsConfig>{
cds: {
tenant: 'my-tenant',
baseUrl: 'my-base-url.com',
Expand Down
1 change: 1 addition & 0 deletions integration-libs/cds/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions integration-libs/digital-payments/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions integration-libs/opps/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions integration-libs/s4om/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions integration-libs/segment-refs/tsconfig.schematics.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { CDS_CONFIG } from '../../constants';
import {
CDS_FEATURE_NAME,
SPARTACUS_CDS,
SPARTACUS_CDS_ASSETS,
TRACKING_PERSONALIZATION_FEATURE_NAME,
} from '../../libs-constants';
import {
Expand All @@ -28,6 +29,9 @@ export const CDS_MODULE_NAME = 'Cds';

export const CDS_MODULE = 'CdsModule';

export const CDS_TRANSLATIONS = 'cdsTranslations';
export const CDS_TRANSLATION_CHUNKS_CONFIG = 'cdsTranslationChunksConfig';

export const CDS_SCHEMATICS_CONFIG: SchematicConfig = {
library: {
featureName: CDS_FEATURE_NAME,
Expand All @@ -42,6 +46,11 @@ export const CDS_SCHEMATICS_CONFIG: SchematicConfig = {
},
customConfig: buildCdsConfig,
dependencyFeatures: [TRACKING_PERSONALIZATION_FEATURE_NAME],
i18n: {
resources: CDS_TRANSLATIONS,
chunks: CDS_TRANSLATION_CHUNKS_CONFIG,
importPath: SPARTACUS_CDS_ASSETS,
},
};

function buildCdsConfig(
Expand Down
2 changes: 2 additions & 0 deletions projects/schematics/src/shared/libs-constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,8 @@ export const SPARTACUS_USER_PROFILE_ROOT = `@spartacus/user/profile/root`;

export const SPARTACUS_CDS = `@spartacus/cds`;

export const SPARTACUS_CDS_ASSETS = `@spartacus/cds/assets`;

export const SPARTACUS_CDP = `@spartacus/cdp`;
export const SPARTACUS_CDP_CUSTOMER_TICKETING =
'@spartacus/cdp/customer-ticketing';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,17 @@
*/

import { NgModule } from '@angular/core';
import {
CdsConfig,
CdsModule,
cdsTranslationChunksConfig,
cdsTranslations,
} from '@spartacus/cds';
import { CdsConfig, CdsModule } from '@spartacus/cds';
import {
I18nConfig,
provideConfig,
provideConfigFactory,
WindowRef,
} from '@spartacus/core';
import {
cdsTranslationChunksConfig,
cdsTranslations,
} from '@spartacus/cds/assets';

const cds1: CdsConfig = {
cds: {
Expand Down
1 change: 1 addition & 0 deletions projects/storefrontapp/tsconfig.app.prod.json
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,7 @@
"@spartacus/cdc/user-profile": ["dist/cdc/user-profile"],
"@spartacus/cdp/customer-ticketing": ["dist/cdp/customer-ticketing"],
"@spartacus/cdp": ["dist/cdp"],
"@spartacus/cds/assets": ["dist/cds/assets"],
"@spartacus/cds": ["dist/cds"],
"@spartacus/digital-payments/assets": ["dist/digital-payments/assets"],
"@spartacus/digital-payments": ["dist/digital-payments"],
Expand Down
1 change: 1 addition & 0 deletions projects/storefrontapp/tsconfig.server.json
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,7 @@
"../../integration-libs/cdp/customer-ticketing/public_api"
],
"@spartacus/cdp": ["../../integration-libs/cdp/public_api"],
"@spartacus/cds/assets": ["../../integration-libs/cds/assets/public_api"],
"@spartacus/cds": ["../../integration-libs/cds/public_api"],
"@spartacus/digital-payments/assets": [
"../../integration-libs/digital-payments/assets/public_api"
Expand Down
1 change: 1 addition & 0 deletions projects/storefrontapp/tsconfig.server.prod.json
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,7 @@
"../../dist/cdp/customer-ticketing"
],
"@spartacus/cdp": ["../../dist/cdp"],
"@spartacus/cds/assets": ["../../dist/cds/assets"],
"@spartacus/cds": ["../../dist/cds"],
"@spartacus/digital-payments/assets": [
"../../dist/digital-payments/assets"
Expand Down
Loading

0 comments on commit 166522a

Please sign in to comment.