Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for object urls to URLListValidator.js #4055

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

igzThomasFrischholz
Copy link

URLListValidator did not support Object-URLs which lead to misbehaviour in some classes. (e.g PDFViewer could not load files from object urls)

This PR aims to fix this issue by adding a regex check and decompose into the validate method of URLListValidator.js
A separate Unit-Test for the desired behavior has been added as well.

Copy link

cla-assistant bot commented May 23, 2024

CLA assistant check
All committers have signed the CLA.

@flovogt
Copy link
Member

flovogt commented May 23, 2024

Thanks a lot for your PR. The team will have a look at it!
Internally tracked via DINC0162093.

@boghyon
Copy link
Contributor

boghyon commented May 26, 2024

blob: URLs are generally considered as insecure as unsafe-eval (See w3c/webappsec-csp@0f497cb and https://www.w3.org/TR/CSP2/#source-list-guid-matching) and might not be explicitly allowed by the CSP configuration set in e.g. Fiori launchpad sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants