-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@sap-ux/odata service inquirer): Adds system selection prompting #2374
base: main
Are you sure you want to change the base?
feat(@sap-ux/odata service inquirer): Adds system selection prompting #2374
Conversation
|
@@ -4,4 +4,5 @@ config.snapshotFormat = { | |||
escapeString: false, | |||
printBasicPrototype: false | |||
}; | |||
config.collectCoverage = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
…quirer)/2373/adds_system_prompt_from_store
…quirer)/2373/adds_system_prompt_from_store
odataVersion?: ODataVersion; | ||
}): Promise<void> { | ||
this.resetConnectionState(); | ||
|
||
if (this.systemAuthType === 'reentranceTicket' || this.systemAuthType === 'serviceKey') { | ||
this._serviceProvider = this.getAbapOnCloudServiceProvider(url, serviceInfo); | ||
} else if (destination) { | ||
// Unclear why aaxiosConfig is mandatory here, its not mandatory in the the target function implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in comment
return this.validity.authRequired; | ||
// Dont re-request if we have already determined the auth requirement or we are authenticated | ||
if (this._validatedUrl === urlString && this._validatedClient === client) { | ||
if (this.validity.authenticated) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (this.validity.authenticated) { | |
if (this.validity.authenticated || this.validity.authReruiqed !== undefined) { | |
return this.validity.authRequired; | |
} |
Quality Gate failedFailed conditions |
#2373
todo: