Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignore cert error to odata-service-writer #2343

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Add ignore cert error to odata-service-writer #2343

merged 2 commits into from
Sep 18, 2024

Conversation

kjose90
Copy link
Member

@kjose90 kjose90 commented Sep 10, 2024 •
edited
Loading

#2326

  • odata-service-writer
    Extended the OdataService interface to include the ignoreCertError property.
  • ui5-config
    Added logic to include ignoreCertError value in yaml file if provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: db509a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kjose90 kjose90 marked this pull request as ready for review September 18, 2024 09:57
@kjose90 kjose90 requested review from a team as code owners September 18, 2024 09:57
tobiasqueck
tobiasqueck approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@tobiasqueck tobiasqueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • change is clear and easy to understand
  • test coverage good
  • no changeset needed because it is not merge to main

devinea
devinea approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes are clear and covered by tests

@kjose90 kjose90 merged commit e43334f into start-variants-management-script Sep 18, 2024
2 checks passed
@kjose90 kjose90 deleted the ignore-certs branch September 18, 2024 13:47
kjose90 added a commit that referenced this pull request Sep 23, 2024
@kjose90 @IainSAP
@longieirl @devinea
Add scripts variant management script to FF & FE package json (#2327)
484195d 
* add scripts variant management

* adding changeset

* fix vairant script

* update snapshots

* changing disableCacheParam var name

* Add sapuxlayer to package json  (#2359)

* add sapuxlayer

* document sapuxLayer property

* update snap shots and set default sapuxLayer

* update test name

* Update index.ts fix typp

* reverting default sap ux layer settings

* use package type from project-access in ui5-application-writer

* Add ignore cert error to odata-service-writer  (#2343)

* add ignore cert error to odata service writer and ui5 config

* lint issues

* Add fiori-tools-preview middleware to ui5 yamls (#2382)

* update fiori preview middleares

* add fiori preview & update snapshots

* add doc to firori middlware type

* Create thin-numbers-repair.md

* Delete .changeset/thin-numbers-repair.md

---------

Co-authored-by: Austin Devine <[email protected]>

* adding default app name to simple generator example app

* update changeset

* snapshot fix

* sonar issue

---------

Co-authored-by: IainSAP <[email protected]>
Co-authored-by: J Long <[email protected]>
Co-authored-by: Austin Devine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinea devinea devinea approved these changes

@tobiasqueck tobiasqueck tobiasqueck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjose90 @devinea @tobiasqueck