Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding preview middle ware and api hub to ui5 writers #2329

Closed
wants to merge 6 commits into from

Conversation

kjose90
Copy link
Member

@kjose90 kjose90 commented Sep 5, 2024

#2326

  • Added start-variants-management script to append & when sapClient info is provided.

  • ui5-application-writer
    Added logic to write the SapUxLayer property to package.json templates.
    Introduced the fiori-tools-preview middleware to both ui5 and ui5-local.yaml configurations.
    Incorporated ApiHubConfig as part of the ui5.appOptions interface, and automatically created a .env file if apiHubConfig is provided.

  • mockserver-config-writer
    Ensured that adding fiori-tools-preview middleware to ui5.yaml will not result in writing it to ui5-mock.yaml, and removed it specifically in ui5-mock-yaml.ts.

  • ui5-config
    Added a function addFioriToolsPreviewMiddleware to insert the fiori-tools-preview middleware into the yaml configuration.

Copy link

changeset-bot bot commented Sep 5, 2024

⚠️ No Changeset found

Latest commit: fb30c0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kjose90 kjose90 marked this pull request as ready for review September 10, 2024 09:24
@kjose90 kjose90 requested review from a team as code owners September 10, 2024 09:24
Copy link

cla-assistant bot commented Sep 10, 2024

CLA assistant check
All committers have signed the CLA.

@kjose90 kjose90 marked this pull request as draft September 10, 2024 12:36
@kjose90 kjose90 changed the title Adding preview middle ware , ignore cert and api hub to ui5 writers Adding preview middle ware and api hub to ui5 writers Sep 10, 2024
@kjose90 kjose90 removed the request for review from a team September 10, 2024 12:51
@kjose90 kjose90 closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant