fix: Modified indicators incorrectly displayed for some UI5 controls in Adaptation Project #2264
Conversation
🦋 Changeset detectedLatest commit: 65d7d2f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nikmace
added
bug
…ub.com/SAP/open-ux-tools into fix/2263/incorrect-modified-indicators
|
the usage of the fl library looks fine. I will document in openui5 that they are used here |
…ub.com/SAP/open-ux-tools into fix/2263/incorrect-modified-indicators
|
| {text} | ||
| </Link> | ||
| </Stack.Item> | ||
| {text && ( |
There was a problem hiding this comment.
text should always be defined and not an empty string.
There was a problem hiding this comment.
Since we use a control group for the new 'control' kind, we do not have the controlName. And controlName is taken from change.selector.type, which for 'renameLabel' and 'addXML' unfortunately does not exist. Therefore, the only way to use the ControlGroup.tsx for kind: 'control' is to hide the text stack item (group header) because we do not have one for this change kind.
Maybe, it does not make sense to process this change in the ControlGroup; maybe we need a third group like ControlChange, then the ChangeStack.tsx will have three options for rendering the change.
| const controlChange: ControlSavedChange = { | ||
| ...unknownChange, | ||
| kind: 'control', | ||
| controlId: selectorId ?? '' |
There was a problem hiding this comment.
?? operator seems unnecessary here as we already check for selectorId before.
| @@ -117,6 +117,7 @@ describe('SelectionService', () => { | |||
| timestamp: 1640106817301 | |||
| }, | |||
| { | |||
| changeType: 'propertyChange', | |||
There was a problem hiding this comment.
This looks wrong. unknown change should not have change type propertyChange. It seems that the unknown also need to be change to property.
| @@ -274,6 +275,7 @@ describe('SelectionService', () => { | |||
| timestamp: 1640106817301 | |||
| }, | |||
| { | |||
| changeType: 'propertyChange', | |||
| timestamp?: number; | ||
| } | ||
|
|
||
| export interface ControlSavedChange { |
There was a problem hiding this comment.
This word order sounds quite strange. It would be better if it matched other change type names e.g PendingControlChange and SavedPropertyChange.
| export interface ControlSavedChange { | |
| export interface SavedControlChange { |
| private async handleCommand(command: FlexCommand, inactiveCommandCount: number, index: number): Promise<void> { | ||
| const pendingChange = await this.prepareChangeType(command, inactiveCommandCount, index); | ||
| if (pendingChange) { | ||
| this.pendingChanges.push(pendingChange); |
There was a problem hiding this comment.
There seems to be an issue with pending changes duplicating on each event. It is probably because pendingChanges field is not reset and we always process all the changes in the stack.
#2263