neoDeploy: assert deployable exists before starting deployment. #631
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to now the presence of the deployable (source) was checked late by the NeoCommandLineHelper. The code doing this is surrounded by the try/catch which finally also puts the log written by the neo toolset into the job log in case an exception occured. The check for the deployable returns with the same type of exception like a failed neo command. Hence we cannot distiguish (ok, would be possible to parse the exception message, but that is ugly). When the exception is triggered by the missing deployable we try to cat the neo log into the job log. But at this point the neo log has not been provided - neo has not been called at all in this case. Hence `cat logs/neo/*` in turn fails. In order to avoid such a failure we check now for the presence of the deployable earlier before launching the neo toolset. Since the deployable is used in any deploy mode case no further check for the deploy mode is required prior to the check for the deployable.
This was referenced Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now the presence of the deployable (source) was checked late
by the NeoCommandLineHelper. The code doing this is surrounded by
the try/catch which finally also puts the log written by the neo
toolset into the job log in case an exception occured.
The check for the deployable returns with the same type of
exception like a failed neo command. Hence we cannot distiguish (ok,
would be possible to parse the exception message, but that is ugly).
When the exception is triggered by the missing deployable we try to
cat the neo log into the job log. But at this point the neo log has
not been provided - neo has not been called at all in this case.
Hence
cat logs/neo/*in turn fails.In order to avoid such a failure we check now for the presence of the
deployable earlier before launching the neo toolset.
Since the deployable is used in any deploy mode case no further check
for the deploy mode is required prior to the check for the deployable.