generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JavaDoc #39
Merged
Merged
Add JavaDoc #39
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e4c602e
add javadoc for the java-access-api module
Johannes-Schneider 4df159b
add javadoc for the java-consumption-api module
Johannes-Schneider 9cf8e16
add javadoc for the java-core-api module
Johannes-Schneider 6518cec
add javadoc for the java-sap-service-operator module
Johannes-Schneider 2c57607
add javadoc for the java-sap-service-operator module
Johannes-Schneider 3832ed5
add javadoc for the java-sap-vcap-services module
Johannes-Schneider f96b378
add release notes markdown file
Johannes-Schneider 8736cf1
formatting
Johannes-Schneider 3dab40b
optimize imports and add more release notes
Johannes-Schneider 6976e69
Merge branch 'main' into add-javadoc
Johannes-Schneider c08d1d3
review feedback
Johannes-Schneider d99fe68
Merge branch 'main' into add-javadoc
Johannes-Schneider 012612f
review feedback
Johannes-Schneider File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that if you offer to manage the global state there is a good chance people will use that, regardless of what the javadoc states 😉
Anyhow, for that purpose the naming "accessor" sounds somewhat odd..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created an issue to consider renaming the Accessors.