chore: Refactor ai-api E2E tests #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deekshas8
reviewed
Oct 2, 2024
ZhongpinWang
requested changes
Oct 9, 2024
ZhongpinWang
requested changes
Oct 9, 2024
marikaner
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Cleanup looks good to me, I noticed that currently the samples are not really samples and I think this will not be very helpful to users. I believe it is ok to use the samples for the E2E tests, but the tests should not guide how we structure our samples, because the purpose is a different one: Samples are for users, tests are for automatic quality insurance.
|
Was finally able to get to the changes for this. I've changed the sample code to hopefully have something useful now. The new retry values and timeouts seem to work well from my testing. |
ZhongpinWang
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/gen-ai-hub-sdk-js-backlog#142.
DeploymentApiandScenarioApiendpoints, some of which are now used in the e2e-tests.Definition of Done
[ ] (Optional) Aligned changes with the Java SDK