chore: Refactor orchestration E2E tests for better coverage #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marikaner
reviewed
Sep 23, 2024
| templating: { | ||
| template: [ | ||
| // define "country" as variable by wrapping it with "{{? ... }}" |
There was a problem hiding this comment.
👍 I like these additional comments for samples!
KavithaSiva
reviewed
Oct 1, 2024
| } catch (error: any) { | ||
| // Handle the case where the output was filtered. | ||
| return `Error: ${error.message}`; | ||
| if (error.response.status === 400) { |
There was a problem hiding this comment.
[pp] Also, typecheck if error instanceof Error. Ideally, we should also check if it is an AxiosError as we are assuming it's structure. But, I guess this would lead to adding a new dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR improves the E2E test coverage for orchestration. In doing so, it asserts that the sample code is functional.
Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updated(Optional) Aligned changes with the Java SDK(Optional) Release notes updated