fis performance issues

SAP · Oct 14, 2024 · 21859eb · 21859eb
1 parent d4a06f0
commit 21859eb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/.changeset/smooth-cameras-care.md b/.changeset/smooth-cameras-care.md
@@ -0,0 +1,5 @@
+---
+'@sap-ai-sdk/langchain': patch
+---
+
+[Fixed Issue] Fix performance issues when creating embeddings for split documents by sending all documents in one request instead of splitting it up in separate requests.
diff --git a/packages/langchain/src/openai/embedding.ts b/packages/langchain/src/openai/embedding.ts
@@ -2,7 +2,8 @@ import { AzureOpenAiEmbeddingClient as AzureOpenAiEmbeddingClientBase } from '@s
 import { Embeddings } from '@langchain/core/embeddings';
 import type {
  AzureOpenAiEmbeddingModel,
- AzureOpenAiEmbeddingParameters
+ AzureOpenAiEmbeddingParameters,
+ AzureOpenAiEmbeddingResponse
 } from '@sap-ai-sdk/foundation-models';
 import type { AzureOpenAiEmbeddingModelParams } from './types.js';
 
@@ -25,22 +26,18 @@ export class AzureOpenAiEmbeddingClient extends Embeddings {
  }
 
  override async embedDocuments(documents: string[]): Promise<number[][]> {
- return Promise.all(
- documents.map(document => this.createEmbedding({ input: document }))
- );
+ return (await this.createEmbeddings({ input: documents })).getEmbeddings();
  }
 
  override async embedQuery(input: string): Promise<number[]> {
- return this.createEmbedding({ input });
+ return (await this.createEmbeddings({ input })).getEmbedding() ?? [];
  }
 
- private async createEmbedding(
+ private async createEmbeddings(
  query: AzureOpenAiEmbeddingParameters
- ): Promise<number[]> {
- return this.caller.callWithOptions(
- {},
- async () =>
- (await this.openAiEmbeddingClient.run(query)).getEmbedding() ?? []
+ ): Promise<AzureOpenAiEmbeddingResponse> {
+ return this.caller.callWithOptions({}, async () =>
+ this.openAiEmbeddingClient.run(query)
  );
  }
 }