Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHKV: Remove required fields low and high #353

Merged
merged 2 commits into from
Apr 22, 2022
Merged

CHKV: Remove required fields low and high #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fb72d4
Remove required fields `low` and `high`
schneidermic0 Apr 21, 2022
0cbf48c
Merge branch 'main' into chkv/fix-required-fields
schneidermic0 Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions file-formats/chkv/chkv-v1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,7 @@
"additionalProperties": false,
"required": [
"sign",
"option",
"low",
"high"
"option"
]
}
}
Expand Down
6 changes: 2 additions & 4 deletions file-formats/chkv/examples/z_aff_example_chkv.chkv.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@
{
"sign": "exclude",
"option": "equals",
"low": "0002470721",
"high": ""
"low": "0002470721"
}
]
},
Expand All @@ -55,8 +54,7 @@
{
"sign": "exclude",
"option": "lessEqual",
"low": "P",
"high": ""
"low": "P"
}
]
}
Expand Down
3 changes: 1 addition & 2 deletions file-formats/chkv/type/zif_aff_chkv_v1.intf.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,10 @@ INTERFACE zif_aff_chkv_v1
option TYPE zif_aff_types_v1=>ty_option,
"! <p class="shorttext">Low</p>
"! The low value of the range
"! $required
"! $showAlways
low TYPE string,
"! <p class="shorttext">High</p>
"! The high value of the range
"! $required
high TYPE string,
END OF ty_range,

Expand Down