SapMachine #1552: Backport to 17: 8269914: Factor out heap printing for G1 young and full gc

[GoeLin]

Backport of https://bugs.openjdk.org/browse/JDK-8269914: Factor out heap printing for G1 young and full gc

For details see also openjdk/jdk17u-dev#1900, this is an identical copy
of the change proposed there regarding 8269914.

fixes #1552

[SapMachine]

Hello @GoeLin, this pull request fulfills all formal requirements.

[GoeLin]

Failing tests: infra issues: "Failed permission check: goelin is missing the Overall/Read permisson"

[RealCLanger]

Failing tests: infra issues: "Failed permission check: goelin is missing the Overall/Read permisson"

No, that's not the issue. Please try once more whether you can access the Jenkins build logs. If it doesn't work, we should check together what's wrong. However, there's probably an issue in the Pipeline script that does the merging. I'll check this.

[RealCLanger]

retest this please

[SapMachine]

Hello @GoeLin, this pull request fulfills all formal requirements.

[GoeLin]

Pre-submit tests: rerun did not help, still looks like an infra issue to me.

[RealCLanger]

Pre-submit tests: rerun did not help, still looks like an infra issue to me.

no, it's all good. The failing tests are "validate-pr-22" which were not supposed to run for a sapmachine17 backport. Probably your initial version of the PR went against branch "sapmachine" and you changed it afterwards?

The validate-pr-17 ran fine, the one test issue for linuxppc64le is an unrelated known problem that will be fixed with an OpenJDK backport.

[reinrich]

Hi Götz,
https://bugs.openjdk.org/browse/JDK-8269914 has issues that are fixed by https://bugs.openjdk.org/browse/JDK-8272651. Will you backport the latter as well?

[GoeLin]

Yes, I intend to do exactly what I did in the OpenJDK PR mentioned above.
That includes 8272651, too.

[reinrich]

Yes, I intend to do exactly what I did in the OpenJDK PR mentioned above. That includes 8272651, too.

I'm confused because this pr is not an exact copy of the OpenJDK PR.
Are you planning to backport 8272651 in a separate pr?

[GoeLin]

Yes, I intend to do 3 PRs on SapMachine, this one, then 8272651 and last 8291753.
It is good practice do keep the granularity of OpenJDK changes.

[reinrich]

Looks good to me.
Cheers, Richard.